Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@jwilling
Copy link
Contributor

Any thoughts about the wording? Does this need the example it currently provides?

Fixes #22.

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use real attributes here? They're not important, but I think using something syntactically valid is a good idea.

It might also make sense to add an example with an explicit class, like:

@property (nonatomic, strong) NSObject<Protocol> *object;
@ghost ghost assigned jspahrsummers Nov 24, 2012
@jwilling
Copy link
Contributor Author

:octocat:

README.md Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the more common id<Protocol> example would help. Perhaps also add that, where possible, extend a new protocol from the root <NSObject> protocol. That would be nice...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this example should include id<Protocol> and NSObject<Protocol> * (to show the two styles), which is what I meant by my original comment.

@galaxas0 This guide is not meant to be as exhaustive as you're suggesting. We only want to list items that are non-obvious, and extending <NSObject> is very common Cocoa convention.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jspahrsummers Oh, alright, I did indeed misunderstand the extensiveness of this guide... thanks! 👍

@dannygreg
Copy link

This gets a 👍 from me.

@jspahrsummers
Copy link
Contributor

📬

@jwilling
Copy link
Contributor Author

Sorry it took so long to get back to you on this one. 📭

@jspahrsummers
Copy link
Contributor

🐺

jspahrsummers added a commit that referenced this pull request Nov 29, 2012
@jspahrsummers jspahrsummers merged commit 1be0484 into github:master Nov 29, 2012
@jspahrsummers jspahrsummers removed their assignment May 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants