This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Add comment about not using dot-syntax when calling super #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| So, this is the style I've been following, but playing devil's advocate: why should it be different? I don't see any good reason not to use dot syntax for this. |
| Yeah, the same thought crossed my mind as I was creating this. I thought it was worth stimulating some discussion though. I'm starting to think we should use dot syntax when calling |
| I agree with that. |
| I don't see any reason not to use it (within our other guidelines). We get the nice separation between state and behaviour etc. etc. |
| 👍 on using it with super. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
in an overridden method.