Skip to content

fix: Consistent max buffer value across Node versions. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

fix: Consistent max buffer value across Node versions. #84

merged 1 commit into from
Dec 17, 2019

Conversation

@MaximDevoir
Copy link
Contributor

@MaximDevoir MaximDevoir commented Dec 6, 2019

Before Node v12, maxBuffer defaulted to 200kb. Node v12+ defaults to 1024kb.

Setting the maxBuffer value allows for a more consistent cross-version Node experience.
@MaximDevoir
fix: Consistent max buffer value across Node versions.
bcc9cc6 
Before Node v12, `maxBuffer` defaulted to 200kb. Node v12+ defaults to 1024kb. Setting the `maxBuffer` value allows for a more consistent cross-version Node experience.
@MaximDevoir
Copy link
Contributor Author

MaximDevoir commented Dec 9, 2019 •
edited
Loading

On large projects that are just beginning to switch to the rules of eslint-plugin-github, using the github-lint tool would crash because there were too many lint errors/warnings. So this PR also raises the buffer for Node v8 and Node v10 environments to prevent github-lint from crashing.
koddsson
koddsson approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

I didn't realize why this was needed originally but your follow up comment cleared that up for me ✨
@koddsson koddsson merged commit 84e5cd7 into github:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@MaximDevoir @koddsson