Add event listener lints #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
keithamus commented Jul 14, 2020
lib/configs/browser.js Outdated
Comment on lines 13 to 16
| 'github/unescaped-html-literal': 'error', | ||
| 'github/no-useless-passive': 'error', | ||
| 'github/no-non-passive-high-frequency-events': 'error', | ||
| 'github/prefer-observers-over-events': 'error' |
There was a problem hiding this comment.
Do we consider this to be a breaking change? Do we want to release this as semver major?
There was a problem hiding this comment.
To answer my own question, precedent exists for this to be semver minor, see #80 which was released as 3.3.0
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus force-pushed the addEventListener-lints branch from 00eb1f3 to 1d3c50c Compare 
koddsson approved these changes Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
This adds 3 new rules to our
config/browsereslint config:github/no-useless-passivegithub/require-passive-eventsgithub/prefer-observersTo read more about these rules, see the documentation md files in
docs/Why?
These represent our ideal best practices of how to author code for the GitHub frontend, and as such we'd like to enforce these rules with static analysis.