Skip to content

C++: Improve alias analysis for indirections #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dave-bartolomeo wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

C++: Improve alias analysis for indirections #1736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8213284
C++: Make `duplicateOperand` query report function name
dave-bartolomeo Aug 14, 2019
d40e9f0
C++: Make `IRVariable` non-abstract
dave-bartolomeo Aug 14, 2019
448e4d4
C++: Print memory accesses on the correct instruction in `PrintSSA`
dave-bartolomeo Aug 14, 2019
9c1eb7e
C++: Add SSA sanity tests
dave-bartolomeo Aug 14, 2019
2abcaed
C++: Refactor some integer constant code
dave-bartolomeo Aug 14, 2019
336b7d3
C++: Update points_to test for new alias analysis
dave-bartolomeo Aug 14, 2019
22b776d
C++: Fix escape tests for alias API changes
dave-bartolomeo Aug 14, 2019
5b2baa4
C++: Add SSA sanity tests to IR tests
dave-bartolomeo Aug 14, 2019
4aab88e
C++: Add SSA test case for new alias analysis
dave-bartolomeo Aug 14, 2019
5385f13
C++: Fix dataflow test expectations for new alias analysis
dave-bartolomeo Aug 14, 2019
d4ae9dd
C++: Alias analysis changes to support precise indirections
dave-bartolomeo Aug 14, 2019
2bc3506
C++: Update `SimpleSSA` to use the new alias analysis API
dave-bartolomeo Aug 14, 2019
352e750
C++: Implement precise analysis of indirections in `AliasedSSA`
dave-bartolomeo Aug 14, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
C++: Make IRVariable non-abstract
  • Loading branch information
@dave-bartolomeo
dave-bartolomeo committed Aug 14, 2019
commit d40e9f02cea9b3128527f53cf104aecdeaaaeb2c
28 changes: 20 additions & 8 deletions cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRVariable.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,35 @@ IRUserVariable getIRUserVariable(Language::Function func, Language::Variable var
* be a user-declared variable (`IRUserVariable`) or a temporary variable
* generated by the AST-to-IR translation (`IRTempVariable`).
*/
abstract class IRVariable extends TIRVariable {
class IRVariable extends TIRVariable {
Language::Function func;

abstract string toString();
string toString() {
none()
}

/**
* Gets the type of the variable.
*/
abstract Language::Type getType();
Language::Type getType() {
none()
}

/**
* Gets the AST node that declared this variable, or that introduced this
* variable as part of the AST-to-IR translation.
*/
abstract Language::AST getAST();
Language::AST getAST() {
none()
}

/**
* Gets an identifier string for the variable. This identifier is unique
* within the function.
*/
abstract string getUniqueId();
string getUniqueId() {
none()
}

/**
* Gets the source location of this variable.
Expand Down Expand Up @@ -100,10 +108,14 @@ class IRUserVariable extends IRVariable, TIRUserVariable {
* stack. This includes all parameters, non-static local variables, and
* temporary variables.
*/
abstract class IRAutomaticVariable extends IRVariable {
class IRAutomaticVariable extends IRVariable {
IRAutomaticVariable() {
this instanceof IRAutomaticUserVariable or
this instanceof IRTempVariable
}
}

class IRAutomaticUserVariable extends IRUserVariable, IRAutomaticVariable {
class IRAutomaticUserVariable extends IRUserVariable {
override Language::AutomaticVariable var;

IRAutomaticUserVariable() {
Expand Down Expand Up @@ -132,7 +144,7 @@ IRTempVariable getIRTempVariable(Language::AST ast, TempVariableTag tag) {
result.getTag() = tag
}

class IRTempVariable extends IRVariable, IRAutomaticVariable, TIRTempVariable {
class IRTempVariable extends IRVariable, TIRTempVariable {
Language::AST ast;
TempVariableTag tag;
Language::Type type;
Expand Down
28 changes: 20 additions & 8 deletions cpp/ql/src/semmle/code/cpp/ir/implementation/raw/IRVariable.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,35 @@ IRUserVariable getIRUserVariable(Language::Function func, Language::Variable var
* be a user-declared variable (`IRUserVariable`) or a temporary variable
* generated by the AST-to-IR translation (`IRTempVariable`).
*/
abstract class IRVariable extends TIRVariable {
class IRVariable extends TIRVariable {
Language::Function func;

abstract string toString();
string toString() {
none()
}

/**
* Gets the type of the variable.
*/
abstract Language::Type getType();
Language::Type getType() {
none()
}

/**
* Gets the AST node that declared this variable, or that introduced this
* variable as part of the AST-to-IR translation.
*/
abstract Language::AST getAST();
Language::AST getAST() {
none()
}

/**
* Gets an identifier string for the variable. This identifier is unique
* within the function.
*/
abstract string getUniqueId();
string getUniqueId() {
none()
}

/**
* Gets the source location of this variable.
Expand Down Expand Up @@ -100,10 +108,14 @@ class IRUserVariable extends IRVariable, TIRUserVariable {
* stack. This includes all parameters, non-static local variables, and
* temporary variables.
*/
abstract class IRAutomaticVariable extends IRVariable {
class IRAutomaticVariable extends IRVariable {
IRAutomaticVariable() {
this instanceof IRAutomaticUserVariable or
this instanceof IRTempVariable
}
}

class IRAutomaticUserVariable extends IRUserVariable, IRAutomaticVariable {
class IRAutomaticUserVariable extends IRUserVariable {
override Language::AutomaticVariable var;

IRAutomaticUserVariable() {
Expand Down Expand Up @@ -132,7 +144,7 @@ IRTempVariable getIRTempVariable(Language::AST ast, TempVariableTag tag) {
result.getTag() = tag
}

class IRTempVariable extends IRVariable, IRAutomaticVariable, TIRTempVariable {
class IRTempVariable extends IRVariable, TIRTempVariable {
Language::AST ast;
TempVariableTag tag;
Language::Type type;
Expand Down
28 changes: 20 additions & 8 deletions cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/IRVariable.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,35 @@ IRUserVariable getIRUserVariable(Language::Function func, Language::Variable var
* be a user-declared variable (`IRUserVariable`) or a temporary variable
* generated by the AST-to-IR translation (`IRTempVariable`).
*/
abstract class IRVariable extends TIRVariable {
class IRVariable extends TIRVariable {
Language::Function func;

abstract string toString();
string toString() {
none()
}

/**
* Gets the type of the variable.
*/
abstract Language::Type getType();
Language::Type getType() {
none()
}

/**
* Gets the AST node that declared this variable, or that introduced this
* variable as part of the AST-to-IR translation.
*/
abstract Language::AST getAST();
Language::AST getAST() {
none()
}

/**
* Gets an identifier string for the variable. This identifier is unique
* within the function.
*/
abstract string getUniqueId();
string getUniqueId() {
none()
}

/**
* Gets the source location of this variable.
Expand Down Expand Up @@ -100,10 +108,14 @@ class IRUserVariable extends IRVariable, TIRUserVariable {
* stack. This includes all parameters, non-static local variables, and
* temporary variables.
*/
abstract class IRAutomaticVariable extends IRVariable {
class IRAutomaticVariable extends IRVariable {
IRAutomaticVariable() {
this instanceof IRAutomaticUserVariable or
this instanceof IRTempVariable
}
}

class IRAutomaticUserVariable extends IRUserVariable, IRAutomaticVariable {
class IRAutomaticUserVariable extends IRUserVariable {
override Language::AutomaticVariable var;

IRAutomaticUserVariable() {
Expand Down Expand Up @@ -132,7 +144,7 @@ IRTempVariable getIRTempVariable(Language::AST ast, TempVariableTag tag) {
result.getTag() = tag
}

class IRTempVariable extends IRVariable, IRAutomaticVariable, TIRTempVariable {
class IRTempVariable extends IRVariable, TIRTempVariable {
Language::AST ast;
TempVariableTag tag;
Language::Type type;
Expand Down