Skip to content

[RFC] extensions.refFormat and packed-refs v2 file format #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed

[RFC] extensions.refFormat and packed-refs v2 file format #1408

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
71c76d4
hashfile: allow skipping the hash function
derrickstolee Oct 21, 2022
030d76f
read-cache: add index.computeHash config option
derrickstolee Oct 24, 2022
4013f99
extensions: add refFormat extension
derrickstolee Oct 10, 2022
0cf6549
config: fix multi-level bulleted list
derrickstolee Nov 3, 2022
3121334
repository: wire ref extensions to ref backends
derrickstolee Oct 24, 2022
531bf1b
refs: allow loose files without packed-refs
derrickstolee Oct 24, 2022
4fcbfed
chunk-format: number of chunks is optional
derrickstolee Nov 1, 2022
a7bf8cb
chunk-format: document trailing table of contents
derrickstolee Nov 1, 2022
ff176b5
chunk-format: store chunk offset during write
derrickstolee Oct 5, 2022
78e585c
chunk-format: allow trailing table of contents
derrickstolee Oct 5, 2022
ebc719f
chunk-format: parse trailing table of contents
derrickstolee Oct 5, 2022
a171a84
refs: extract packfile format to new file
derrickstolee Oct 25, 2022
f141d85
packed-backend: extract add_write_error()
derrickstolee Oct 25, 2022
cca445c
packed-backend: extract iterator/updates merge
derrickstolee Oct 25, 2022
a3819f6
packed-backend: create abstraction for writing refs
derrickstolee Oct 25, 2022
7c1f6a1
config: add config values for packed-refs v2
derrickstolee Oct 25, 2022
eb6152f
packed-backend: create shell of v2 writes
derrickstolee Oct 25, 2022
740c2f6
packed-refs: write file format version 2
derrickstolee Oct 25, 2022
701c5ad
packed-refs: read file format v2
derrickstolee Oct 25, 2022
9b3bd93
packed-refs: read optional prefix chunks
derrickstolee Oct 25, 2022
36f9aa0
packed-refs: write prefix chunks
derrickstolee Oct 25, 2022
6fe60ef
packed-backend: create GIT_TEST_PACKED_REFS_VERSION
derrickstolee Oct 26, 2022
188a55d
t1409: test with packed-refs v2
derrickstolee Oct 26, 2022
191ad7f
t5312: allow packed-refs v2 format
derrickstolee Oct 26, 2022
f8b9f35
t5502: add PACKED_REFS_V1 prerequisite
derrickstolee Oct 26, 2022
e6ed6e7
t3210: require packed-refs v1 for some tests
derrickstolee Oct 26, 2022
5aa0d40
t*: skip packed-refs v2 over http tests
derrickstolee Oct 26, 2022
9d261a5
ci: run GIT_TEST_PACKED_REFS_VERSION=2 in some builds
derrickstolee Oct 26, 2022
a4a69d8
p1401: create performance test for ref operations
derrickstolee Nov 3, 2022
37fb4e7
refs: skip hashing when writing packed-refs v2
derrickstolee Nov 3, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
t3210: require packed-refs v1 for some tests 
Three tests in t3210-pack-refs.sh corrupt a packed-refs file to test that Git properly discovers and handles those failures. These tests assume that the file is in the v1 format, so add the PACKED_REFS_V1 prereq to skip these tests when GIT_TEST_PACKED_REFS_VERSION=2. Signed-off-by: Derrick Stolee <derrickstolee@github.com>
  • Loading branch information
@derrickstolee
derrickstolee committed Nov 4, 2022
commit e6ed6e7607c4ce81876f281152c675fc14f0498c
6 changes: 3 additions & 3 deletions t/t3210-pack-refs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ test_expect_success 'notice d/f conflict with existing ref' '
test_must_fail git branch foo/bar/baz/lots/of/extra/components
'

test_expect_success 'reject packed-refs with unterminated line' '
test_expect_success PACKED_REFS_V1 'reject packed-refs with unterminated line' '
cp .git/packed-refs .git/packed-refs.bak &&
test_when_finished "mv .git/packed-refs.bak .git/packed-refs" &&
printf "%s" "$HEAD refs/zzzzz" >>.git/packed-refs &&
Expand All @@ -206,7 +206,7 @@ test_expect_success 'reject packed-refs with unterminated line' '
test_cmp expected_err err
'

test_expect_success 'reject packed-refs containing junk' '
test_expect_success PACKED_REFS_V1 'reject packed-refs containing junk' '
cp .git/packed-refs .git/packed-refs.bak &&
test_when_finished "mv .git/packed-refs.bak .git/packed-refs" &&
printf "%s\n" "bogus content" >>.git/packed-refs &&
Expand All @@ -215,7 +215,7 @@ test_expect_success 'reject packed-refs containing junk' '
test_cmp expected_err err
'

test_expect_success 'reject packed-refs with a short SHA-1' '
test_expect_success PACKED_REFS_V1 'reject packed-refs with a short SHA-1' '
cp .git/packed-refs .git/packed-refs.bak &&
test_when_finished "mv .git/packed-refs.bak .git/packed-refs" &&
printf "%.7s %s\n" $HEAD refs/zzzzz >>.git/packed-refs &&
Expand Down