Fix Debian package build script copy command #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Debian package build script incorrectly copies the containing directory to the destination tree rather than just the contents recursively. This means we end up with: usr └── local ├── bin │ ├── Atlassian.Bitbucket.UI -> ../share/gcm-core/Atlassian.Bitbucket.UI │ ├── git-credential-manager-core -> ../share/gcm-core/git-credential-manager-core │ └── GitHub.UI -> ../share/gcm-core/GitHub.UI └── share └── gcm-core ** ---> └── Release ├── Atlassian.Bitbucket.UI ├── git-credential-manager-core ├── GitHub.UI ├── libHarfBuzzSharp.so ├── libSkiaSharp.so └── NOTICE ..rather than: usr └── local ├── bin │ ├── Atlassian.Bitbucket.UI -> ../share/gcm-core/Atlassian.Bitbucket.UI │ ├── git-credential-manager-core -> ../share/gcm-core/git-credential-manager-core │ └── GitHub.UI -> ../share/gcm-core/GitHub.UI └── share └── gcm-core ├── Atlassian.Bitbucket.UI ├── git-credential-manager-core ├── GitHub.UI ├── libHarfBuzzSharp.so ├── libSkiaSharp.so └── NOTICE Since the symlinks are wrong, the installation is broken.
dscho approved these changes Nov 18, 2021
Contributor
dscho left a comment
dscho left a comment There was a problem hiding this comment.
At least you have a way to work around it, but I agree that it is annoying.
Contributor Author
| Yeah the workaround would be one of:
|
Remove the symlinks to the GitHub and Bitbucket UI helpers in /usr/local/bin. These are not required to have the core GCM application locate the helpers and just create more noise in the user's $PATH.
ldennington approved these changes Nov 18, 2021
Contributor Author
| Note that I'm merging this without the CodeQL task completing. It appears to be stuck (over 5 hours!) |
Contributor
I believe that @ldennington has fixed this by removing the CodeQL definition and adding it back. At least the latest build succeeded, after you merged: https://github.com/GitCredentialManager/git-credential-manager/actions/runs/1479362393 |
This was referenced Dec 10, 2021
Merged
| | ||
| # Copy all binaries and shared libraries to target installation location | ||
| cp -R "$PAYLOAD" "$INSTALL_TO" || exit 1 | ||
| cp -R "$PAYLOAD"/* "$INSTALL_TO" || exit 1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Debian package build script incorrectly copies the containing directory to the destination tree rather than just the contents recursively. We also create extra symlinks for the UI helpers which isn't needed.
This means we end up with:
..rather than:
Since the symlinks are wrong, the installation is broken.