Skip to content

Conversation

@MrOnion
Copy link
Contributor

@MrOnion MrOnion commented Dec 21, 2012

Modified DescribeCommand.java findDirtyState method to not use the jgit status objects isClean method. Instead check all necessary things separately. Only difference between the isClean is that I don't check untracked files.

Tests seems to run ok. Didn't have time to do a separate testcase for this, sorry.

Hope this helps.

Merry christmas and happy new year!

// Ari

untracked files. JGit does this, so we cannot use the isClean method to get the same behaviour.
@fredcooke
Copy link
Contributor

Thanks Ari! Most appreciated!

@ghost ghost assigned ktoso Dec 21, 2012
@ktoso
Copy link
Collaborator

ktoso commented Dec 21, 2012

Thanks a lot guys 👍
Will release during lunch time today (EU time), as a christmas gift! ;-)

@fredcooke
Copy link
Contributor

Best. Christmas. Gift. Ever. :-)

ktoso added a commit that referenced this pull request Dec 21, 2012
@ktoso ktoso merged commit 1a72a48 into git-commit-id:master Dec 21, 2012
@ktoso
Copy link
Collaborator

ktoso commented Dec 21, 2012

Released to oss sonatype, will be mirrored to maven central soon.

resolves #47, with kudos to @MrOnion

@fredcooke
Copy link
Contributor

Still 404 for me, but that sonatype oss server always seems to be slower than it's supposed to be (3 hours):

http://repo1.maven.org/maven2/pl/project13/maven/git-commit-id-plugin/2.1.3

@ktoso
Copy link
Collaborator

ktoso commented Dec 22, 2012

It's up now :)

@fredcooke
Copy link
Contributor

HOORAY! :-) Thanks again :-)

@ktoso
Copy link
Collaborator

ktoso commented Dec 25, 2012

Merry 🎄 day! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants