test: add tests for either FastMCP implementation #5075
+1,046 −43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
❌ 79 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| dramatiq: TESTPATH=tests/integrations/dramatiq | ||
| falcon: TESTPATH=tests/integrations/falcon | ||
| fastapi: TESTPATH=tests/integrations/fastapi | ||
| fastmcp: TESTPATH=tests/integrations/fastmcp |
There was a problem hiding this comment.
Bug: The fastmcp tox environment's TESTPATH in tox.ini line 808 points to a non-existent directory, preventing test discovery.
Severity: HIGH | Confidence: 1.00
🔍 Detailed Analysis
The fastmcp tox environment's TESTPATH is incorrectly configured in tox.ini at line 808. It points to tests/integrations/fastmcp, a non-existent directory. The actual test file, test_fastmcp.py, resides in tests/integrations/mcp. This misconfiguration prevents pytest from discovering and executing any tests for the fastmcp integration suite, resulting in a silent failure where no tests are run.
💡 Suggested Fix
Update tox.ini line 808 to set fastmcp: TESTPATH=tests/integrations/mcp. This will correctly direct pytest to the location of the fastmcp integration tests.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: tox.ini#L808 Potential issue: The `fastmcp` tox environment's `TESTPATH` is incorrectly configured in `tox.ini` at line 808. It points to `tests/integrations/fastmcp`, a non-existent directory. The actual test file, `test_fastmcp.py`, resides in `tests/integrations/mcp`. This misconfiguration prevents `pytest` from discovering and executing any tests for the `fastmcp` integration suite, resulting in a silent failure where no tests are run. Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
There was a problem hiding this comment.
I would put the new tests in a new tests/integrations/fastmcp directory.
If we changed the TESTPATH of the fastmcp entry to be tests/integrations/mcp, then we would be running mcp tests twice in our CI.
| @@ -0,0 +1,3 @@ | |||
| import pytest | |||
| | |||
| pytest.importorskip("mcp") | |||
There was a problem hiding this comment.
Bug: Import Check Misroutes Tests to Wrong Package
The __init__.py file for fastmcp tests imports "mcp" instead of "fastmcp". This causes tests to be skipped when the mcp package is not installed, even though the tests are specifically for the fastmcp package. Since these are separate packages (as evidenced by the separate test directories and tox configuration), the importorskip should check for "fastmcp" availability, not "mcp".
Contributor Author
There was a problem hiding this comment.
That is on purpose, because FastMCP can either be a part of the MCP SDK or a standalone package but both are dependant on mcp
Contributor
| There are CI failures due to version bumps picked up by |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issues
Closes https://linear.app/getsentry/issue/TET-1329/fastmcp-tests
Reminders
tox -e linters.feat:,fix:,ref:,meta:)