fix(tracing): Fix InvalidOperation #4179
Merged
+32 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`InvalidOperation` can occur when using tracing if the `Decimal` class's global context has been modified to set the precision below 6. This change fixes this bug by setting a custom context for our `quantize` call. Fixes #4177
sentrivana approved these changes Mar 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@ ## master #4179 +/- ## ======================================= Coverage 79.56% 79.56% ======================================= Files 141 141 Lines 15736 15736 Branches 2675 2675 ======================================= + Hits 12520 12521 +1 Misses 2369 2369 + Partials 847 846 -1
|
sl0thentr0py approved these changes Mar 20, 2025
szokeasaurusrex deleted the szokeasaurusrex/fix-decimal-invalid-operation branch antonpirker pushed a commit that referenced this pull request Mar 21, 2025
`InvalidOperation` can occur when using tracing if the `Decimal` class's global context has been modified to set the precision below 6. This change fixes this bug by setting a custom context for our `quantize` call. Fixes #4177
sentrivana added a commit that referenced this pull request Mar 21, 2025
`InvalidOperation` can occur when using tracing if the `Decimal` class's global context has been modified to set the precision below 6. This change fixes this bug by setting a custom context for our `quantize` call. Fixes #4177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
InvalidOperationcan occur when using tracing if theDecimalclass's global context has been modified to set the precision below 6. This change fixes this bug by setting a custom context for ourquantizecall.Fixes #4177