[feat: basic logging integration #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
untitaker commented Jul 18, 2018
sentry_sdk/integrations/logging.py Outdated
| 'params': record.args | ||
| } | ||
| | ||
| # TODO: also send formatted message |
Member Author
There was a problem hiding this comment.
Unclear where this should go. @jan-auer said event['message'] was deprecated, but it's used in this sdk already. Let's talk tomorrow.
Contributor
There was a problem hiding this comment.
message is not deprecated but you can use logentry if you have messages with parameters (only %s is supported though).
Member Author
There was a problem hiding this comment.
I already do that. I was under the impression that the integration is supposed to send both the formatted and unformatted message. Is this wrong?
Contributor
There was a problem hiding this comment.
It only needs to send one or the other.
untitaker changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.