Fixed Celery headers for Beat auto-instrumentation #2102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…:getsentry/sentry-python into antonpirker/fix-crons-header-propagation
sentrivana approved these changes May 12, 2023
Contributor
sentrivana left a comment
sentrivana left a comment There was a problem hiding this comment.
Found a typo, otherwise lgtm!
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Without this only the "IN_PROGRESS" check ins for Celery Beat tasks are sent to Sentry but the "OK" or "ERROR" events are ignored, because the hooks do not have the information about what Cron monitor they are related to.
Fixes #2104