Allow logging exceptions #1035
Merged
Allow logging exceptions #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Litarnus approved these changes Sep 9, 2025
Co-authored-by: Martin Linzmayer <martin.linzmayer@sentry.io>
stayallive approved these changes Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of #1034, I decided to allow logging exceptions instead.
While we could emit logs for unhandled exceptions that bubble up to Laravel's error handler, we would miss all
captureException()calls.Attaching an
event_idis not feasible either, as we don't know if the event id is a transaction or an error event. The trace correlation from the log to an error event must suffice for now.Lastly, I had to create a copy of the context in order being able to mutate it, due to https://github.com/Seldaek/monolog/blob/main/src/Monolog/LogRecord.php#L35.