Remove need for context in Sentry.init for Android #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
markushi approved these changes Aug 11, 2023
sentry-kotlin-multiplatform/src/androidMain/AndroidManifest.xml Outdated Show resolved Hide resolved
| @BeforeTest | ||
| open fun setUp() { | ||
| // Set up the provider needed for Sentry.init on Android | ||
| val provider = Robolectric.buildContentProvider(ContextProvider::class.java) |
...ltiplatform/src/androidUnitTest/kotlin/io/sentry/kotlin/multiplatform/ContextProviderTest.kt Outdated Show resolved Hide resolved
| * This does not allow for overriding the abstract query, insert, update, and delete operations | ||
| * of the [ContentProvider]. | ||
| */ | ||
| internal class ContextProvider : ContentProvider() { |
There was a problem hiding this comment.
I think the default proguard rules already exclude any ContentProvider classes from being obfuscated these days, but maybe worth double checking if the name is kept in a release build.
There was a problem hiding this comment.
Yup, it's not obfuscated in the release build
ArnyminerZ added a commit to FilaMagenta/App that referenced this pull request Nov 14, 2023
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ref #114
Eliminates the need for context in init - context can be passed in through a simple
ContextProvider.