-
- Notifications
You must be signed in to change notification settings - Fork 1.7k
polish raven.d.ts #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
polish raven.d.ts #827
Changes from 1 commit
Commits
Show all changes
23 commits Select commit Hold shift + click to select a range
ef30661 polished raven.d.ts
LucaVazz 98a83c1 updated author information of raven.d.ts
LucaVazz 2e590d2 added extra to RavenUserContext
LucaVazz cc9fc47 small fixes
LucaVazz 592e542 copied fixes from PR in DefenitivelyTyped
LucaVazz 089efdd fixed tsc --noEmit --noImplicitAny typescript/raven-tests.ts
LucaVazz 305d38b made `data: any` in set...Calback more specific
LucaVazz 949bc5d added missing values to RavenOutgoingData
LucaVazz d0d32c8 replaced any in setBreadcrumbCallback
LucaVazz e562d5c made options for setTransport more specific
LucaVazz a53a044 set user in RavenOutgoingData to RavenUserContext instead of any
LucaVazz f46fde8 fixed missed RavenTransportOptions (-> RavenTransportFunctionOptions …
LucaVazz 7fdef1f fixed interface-props terminated by `;` to be terminated by `;`
LucaVazz 9f38a30 Merge branch 'master' of https://github.com/getsentry/raven-js
LucaVazz 1f55f01 re-added accidentally deleted tests (in a fixed version)
LucaVazz 3e51fc6 fixed typo in RavenBreadcrumbOptions
LucaVazz ac60fe3 added a proposal for a PR-Template
LucaVazz 10d48cc removed redundant testing from the PR-Template
LucaVazz 60a7809 fix optionals in RavenBreadcrumb
LucaVazz 5e92191 added tests for captureBreadcrumb
LucaVazz 634908c fixed erroneous optionals from the last commit
LucaVazz d8941cf removed PR-Template
LucaVazz e034ba6 Merge branch 'master' of https://github.com/LucaVazz/raven-js
LucaVazz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
copied fixes from PR in DefenitivelyTyped
- Loading branch information
commit 592e542247be1ccd9801d569446f99731860dafc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,7 @@ | ||
| // Type definitions for Raven.js | ||
| // Type definitions for Raven.js | ||
| // Project: https://github.com/getsentry/raven-js | ||
| // Original Definitions by: Santi Albo <https://github.com/santialbo>, Benjamin Pannell | ||
| // <http://github.com/spartan563>; DefinitelyTyped | ||
| // Updated by: Ben Vinegar <https://github.com/benvinegar>, Ilya Pirogov | ||
| // <https://github.com/ilya-pirogov>, Eli White <https://github.com/TheSavior>, David Cramer | ||
| // <https://github.com/dcramer>, Connor Peet <https://github.com/connor4312>, comaz | ||
| // <https://github.com/combmag>, Luca Vazzano <https://github.com/LucaVazz> | ||
| // Definitions by: Santi Albo <https://github.com/santialbo/>, Benjamin Pannell <http://github.com/spartan563>, Gary Blackwood <http://github.com/Garee>, Rich Rout <http://github.com/richrout>, Ben Vinegar <https://github.com/benvinegar>, Ilya Pirogov <https://github.com/ilya-pirogov>, Eli White <https://github.com/TheSavior>, David Cramer <https://github.com/dcramer>, Connor Peet <https://github.com/connor4312>, comaz <https://github.com/combmag>, Luca Vazzano <https://github.com/LucaVazz> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
| | ||
| | ||
| declare let Raven: RavenStatic; | ||
| | @@ -200,7 +196,7 @@ interface RavenStatic { | |
| | ||
| | ||
| // --- Helper Interfaces for Options -------------- | ||
| interface RavenBreadcrumOptions { | ||
| export interface RavenBreadcrumOptions { | ||
| /** Whether to collect XHR calls, defaults to true */ | ||
| xhr?: boolean; | ||
| | ||
| | @@ -214,7 +210,7 @@ interface RavenBreadcrumOptions { | |
| location?: boolean; | ||
| } | ||
| | ||
| interface CommonRavenOptions { | ||
| export interface CommonRavenOptions { | ||
| /** The environment of the application you are monitoring with Sentry */ | ||
| environment?: string; | ||
| | ||
| | @@ -234,7 +230,7 @@ interface CommonRavenOptions { | |
| stacktrace?: boolean; | ||
| } | ||
| | ||
| interface RavenOptions extends CommonRavenOptions { | ||
| export interface RavenOptions extends CommonRavenOptions { | ||
| /** The name of the server or device that the client is running on */ | ||
| server_name?: string; | ||
| | ||
| | @@ -253,7 +249,7 @@ interface RavenOptions extends CommonRavenOptions { | |
| platform?: string; | ||
| } | ||
| | ||
| interface RavenGlobalOptions extends CommonRavenOptions { | ||
| export interface RavenGlobalOptions extends CommonRavenOptions { | ||
| /** The name of the server or device that the client is running on */ | ||
| serverName?: string; | ||
| | ||
| | @@ -294,12 +290,12 @@ interface RavenGlobalOptions extends CommonRavenOptions { | |
| dataCallback?: (data: any) => any; | ||
| } | ||
| | ||
| interface RavenWrapOptions extends RavenOptions { | ||
| export interface RavenWrapOptions extends RavenOptions { | ||
| /** Whether to run the wrap recursively. Default: false. */ | ||
| deep?: boolean; | ||
| } | ||
| | ||
| interface RavenTransportOptions { | ||
| export interface RavenTransportOptions { | ||
| url: string; | ||
| data: any; | ||
| auth: { | ||
| | @@ -311,7 +307,7 @@ interface RavenTransportOptions { | |
| onFailure: () => void; | ||
| } | ||
| | ||
| interface RavenReportDialogOptions { | ||
| export interface RavenReportDialogOptions { | ||
| eventId?: number, | ||
| dsn?: string, | ||
| user?: { | ||
| | @@ -322,19 +318,19 @@ interface RavenReportDialogOptions { | |
| | ||
| | ||
| // --- Helper Interfaces for complex Data Structures -------------- | ||
| interface RavenPlugin { | ||
| export interface RavenPlugin { | ||
| (raven: RavenStatic, ...args: any[]): RavenStatic; | ||
| } | ||
| | ||
| interface RavenUserContext { | ||
| export interface RavenUserContext { | ||
| id?: string; | ||
| username?: string; | ||
| email?: string; | ||
| ip_address?: string; | ||
| extra?: { [prop: string]: any }; | ||
| } | ||
| | ||
| interface RavenBreadcrumb { | ||
| export interface RavenBreadcrumb { | ||
| message: string; | ||
| data: { [id: string]: string }; | ||
| ||
| category: string; | ||
| | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo:
BreadcrumThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 3e51fc6