Skip to content

Don't access document if undefined #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benvinegar merged 1 commit into from
Sep 16, 2015
Merged

Don't access document if undefined #383

benvinegar merged 1 commit into from
Sep 16, 2015

Conversation

@benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Sep 16, 2015

No description provided.

mattrobenolt
mattrobenolt reviewed Sep 16, 2015
View reviewed changes
src/raven.js Outdated
Copy link
Contributor

@mattrobenolt mattrobenolt Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use isUndefined(document)?
Copy link
Contributor Author

@benvinegar benvinegar Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.
Copy link
Contributor Author

@benvinegar benvinegar Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought – isUndefined is declared halfway through the file, and I like the declaration of hasDocument at the very top in that big var statement.
Copy link
Contributor

@mattrobenolt mattrobenolt Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it gets hoisted, yo.
Copy link
Contributor Author

@benvinegar benvinegar Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it does, but it seems gross to assume that a function is hoisted on the very first JavaScript statement in a file.
Copy link
Contributor

@mattrobenolt mattrobenolt Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benvinegar benvinegar force-pushed the no-document branch 3 times, most recently from a59513e to 769ab0b Compare September 16, 2015 19:48
benvinegar added a commit that referenced this pull request Sep 16, 2015
@benvinegar
Merge pull request #383 from getsentry/no-document
4db9b1d 
Don't access document if undefined
@benvinegar benvinegar merged commit 4db9b1d into master Sep 16, 2015
@mattrobenolt mattrobenolt deleted the no-document branch October 22, 2015 22:33
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@benvinegar @mattrobenolt