Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Dec 10, 2025

Fixes the case that the instrumentation defaulted to GET in case undefined was parsed as a second fetch argument.

const request = new Request("https://httpbin.org/post", { method: "POST" }); const response = await fetch(request, undefined); <-- will be GET (should be POST)

Closes #18455 (added automatically)

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.81 kB +0.02% +3 B 🔺
@sentry/browser - with treeshaking flags 23.3 kB -0.02% -4 B 🔽
@sentry/browser (incl. Tracing) 41.55 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Profiling) 46.14 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) 79.97 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.7 kB +0.03% +15 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 84.64 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 96.89 kB +0.01% +8 B 🔺
@sentry/browser (incl. Feedback) 41.52 kB +0.08% +32 B 🔺
@sentry/browser (incl. sendFeedback) 29.49 kB +0.01% +1 B 🔺
@sentry/browser (incl. FeedbackAsync) 34.48 kB +0.05% +15 B 🔺
@sentry/react 26.52 kB +0.01% +1 B 🔺
@sentry/react (incl. Tracing) 43.75 kB +0.03% +11 B 🔺
@sentry/vue 29.27 kB +0.07% +20 B 🔺
@sentry/vue (incl. Tracing) 43.36 kB +0.05% +18 B 🔺
@sentry/svelte 24.82 kB -0.02% -4 B 🔽
CDN Bundle 27.24 kB +0.1% +26 B 🔺
CDN Bundle (incl. Tracing) 42.23 kB +0.04% +15 B 🔺
CDN Bundle (incl. Tracing, Replay) 78.75 kB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 84.21 kB +0.02% +9 B 🔺
CDN Bundle - uncompressed 80.04 kB +0.11% +80 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 125.39 kB +0.05% +52 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 241.42 kB +0.03% +52 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.18 kB +0.03% +52 B 🔺
@sentry/nextjs (client) 45.97 kB +0.03% +11 B 🔺
@sentry/sveltekit (client) 41.92 kB +0.06% +21 B 🔺
@sentry/node-core 51.27 kB -0.01% -1 B 🔽
@sentry/node 159.53 kB - -
@sentry/node - without tracing 92.85 kB - -
@sentry/aws-serverless 108.14 kB - -

View base workflow run

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,871 - 8,696 +2%
GET With Sentry 1,693 19% 1,699 -0%
GET With Sentry (error only) 6,098 69% 6,010 +1%
POST Baseline 1,204 - 1,126 +7%
POST With Sentry 602 50% 580 +4%
POST With Sentry (error only) 1,062 88% 1,050 +1%
MYSQL Baseline 3,314 - 3,339 -1%
MYSQL With Sentry 443 13% 453 -2%
MYSQL With Sentry (error only) 2,713 82% 2,684 +1%

View base workflow run

Copy link
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1gr1d s1gr1d merged commit fd67c19 into develop Dec 10, 2025
208 checks passed
@s1gr1d s1gr1d deleted the sig/request-parsing branch December 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants