feat(tracing): strip inline media from messages #18413
Merged
+633 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
isaacs added a commit that referenced this pull request Dec 4, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 7c5aad2 to 3512099 Compare 
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
isaacs added a commit that referenced this pull request Dec 5, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 3512099 to 5d7bbc8 Compare isaacs added a commit that referenced this pull request Dec 8, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. If any truncation occurs, then a `client.recordDroppedEvent()` message is fired, with the reason `before_send`, category `attachment`, and the count of messages affected. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 5d7bbc8 to 3e58d4b Compare isaacs added a commit that referenced this pull request Dec 8, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. If any truncation occurs, then a `client.recordDroppedEvent()` message is fired, with the reason `before_send`, category `attachment`, and the count of messages affected. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 3e58d4b to 687dd68 Compare 
RulaKhaled approved these changes Dec 9, 2025
shellmayr reviewed Dec 9, 2025
isaacs added a commit that referenced this pull request Dec 9, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. If any truncation occurs, then a `client.recordDroppedEvent()` message is fired, with the reason `before_send`, category `attachment`, and the count of messages affected. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 687dd68 to 0b22140 Compare isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. If any truncation occurs, then a `client.recordDroppedEvent()` message is fired, with the reason `before_send`, category `attachment`, and the count of messages affected. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 0b22140 to 6692634 Compare isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. If any truncation occurs, then a `client.recordDroppedEvent()` message is fired, with the reason `before_send`, category `attachment`, and the count of messages affected. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 6692634 to f3ccd12 Compare isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from f3ccd12 to ba36a66 Compare isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from ba36a66 to 816ad3e Compare ![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 816ad3e to 22a1a57 Compare isaacs added a commit that referenced this pull request Dec 10, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 22a1a57 to 1095669 Compare isaacs added a commit that referenced this pull request Dec 11, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 1095669 to 13bdae3 Compare isaacs added a commit that referenced this pull request Dec 11, 2025
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 13bdae3 to 8db1461 Compare 
This is the functional portion addressing JS-1002. Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data. If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large. Re JS-1002 Re GH-17810
isaacs force-pushed the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch from 8db1461 to 37b5364 Compare isaacs deleted the isaacschlueter/js-1002-drop-media-from-messages-in-sdks-and-document-behavior branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the functional portion addressing JS-1002.
Prior to truncating text messages for their byte length, any inline base64-encoded media properties are filtered out. This allows the message to possibly be included in the span, indicating to the user that a media object was present, without overflowing the allotted buffer for sending data.
If a media message is not removed, the fallback is still to simply remove it if its overhead grows too large.
Re JS-1002
Re GH-17810
Message truncation (for text length and inline media) still needs to be added to the docs.