Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Dec 3, 2025

This fix will check for a msg field in the logger call (https://getpino.io/#/docs/api?id=messagekey-string) if there was no message string passed:

logger.info("This was always logged"); logger.info({ msg: "This now gets logged too" }); // This pr adds support for this

closes #18381
closes https://linear.app/getsentry/issue/JS-1245/pinotransport-ignores-msg-field

@chargome chargome self-assigned this Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,967 - 8,876 +1%
GET With Sentry 1,669 19% 1,739 -4%
GET With Sentry (error only) 5,930 66% 6,212 -5%
POST Baseline 1,183 - 1,210 -2%
POST With Sentry 587 50% 603 -3%
POST With Sentry (error only) 1,039 88% 1,083 -4%
MYSQL Baseline 3,270 - 3,321 -2%
MYSQL With Sentry 394 12% 524 -25%
MYSQL With Sentry (error only) 2,669 82% 2,731 -2%

View base workflow run

@chargome chargome merged commit e559d73 into develop Dec 3, 2025
284 of 287 checks passed
@chargome chargome deleted the cg-JS-1245/pinotransport-ignores-msg-field branch December 3, 2025 11:51
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants