fix(aws-serverless): Remove hyphens from AWS-lambda origins #18353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch from 2597696 to 3385c75 Compare 
Lms24 approved these changes Nov 28, 2025
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch from 17a7223 to 21a5d4f Compare 
AbhiPrasad approved these changes Nov 28, 2025
Member
| Looks like we still need to fix some of the e2e tests |
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch from 21a5d4f to 4a3b2fb Compare 
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch 6 times, most recently from 525c1cf to 9eb5827 Compare ![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/aws-serverless/src/stack.ts Outdated Show resolved Hide resolved
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch 2 times, most recently from 9923e93 to 4e5098e Compare 
onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch 2 times, most recently from f7a38ac to b8f6523 Compare onurtemizkan force-pushed the onur/remove-hyphens-from-aws-lambda-origins branch from b8f6523 to d21ae31 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following up: #18351
Looks like these are also forgotten in hyphens