fix(tracing): Add missing attributes in vercel-ai spans #18333
Merged
+389 −250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
isaacs added a commit that referenced this pull request Nov 26, 2025
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from e14c708 to 830aa2e Compare ![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
isaacs added a commit that referenced this pull request Nov 26, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 830aa2e to f5b9b31 Compare 
RulaKhaled reviewed Nov 27, 2025
Member
RulaKhaled left a comment
RulaKhaled left a comment There was a problem hiding this comment.
The logic lgtm, I left some quick comments. We also need to a. update tests for Vercel v5 (it's a nested folder within vercel node integration tests) and b. run yarn fix in the root folder to fix lint issues
isaacs added a commit that referenced this pull request Dec 1, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216
isaacs added a commit that referenced this pull request Dec 1, 2025
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from f5b9b31 to 346d3b3 Compare isaacs added a commit that referenced this pull request Dec 1, 2025
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
isaacs added a commit that referenced this pull request Dec 2, 2025
isaacs added a commit that referenced this pull request Dec 2, 2025
isaacs added a commit that referenced this pull request Dec 2, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from caa6430 to a181428 Compare 
Member Author
| Resolved cursor and JS-1236. |
isaacs added a commit that referenced this pull request Dec 2, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from a181428 to 8c73ce1 Compare isaacs added a commit that referenced this pull request Dec 2, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 8c73ce1 to 8f47b16 Compare isaacs added a commit that referenced this pull request Dec 2, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 8f47b16 to bf872b5 Compare isaacs added a commit that referenced this pull request Dec 3, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from bf872b5 to 5e76e74 Compare 
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 5e76e74 to 4431746 Compare isaacs deleted the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix JS-1216
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).