fix(core): Always redact content of sensitive headers regardless of sendDefaultPii #18311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…less of `sendDefaultPii`
Lms24 approved these changes Nov 24, 2025
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines 153 to 147
| export function httpHeadersToSpanAttributes( | ||
| headers: Record<string, string | string[] | undefined>, | ||
| sendDefaultPii: boolean = false, | ||
| ): Record<string, string> { | ||
| const spanAttributes: Record<string, string> = {}; | ||
| | ||
| try { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
| (For transparency: We reviewed this PR offline prior to opening it, therefore the comment-less ✅ ) |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This was referenced Dec 9, 2025
s1gr1d added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In case an HTTP header is considered "sensitive" (could contain tokens), the value is already filtered within the SDK.
Follow-up on this PR: