feat(core): Use maxValueLength on error messages

[s1gr1d]

It can happen that error messages are too long and exceed the maximum envelope size (mentioned in #18219). maxValueLength now also checks for long error messages and truncates them.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	24.79 kB	+0.07%	+16 B 🔺
@sentry/browser - with treeshaking flags	23.3 kB	+0.1%	+23 B 🔺
@sentry/browser (incl. Tracing)	41.53 kB	+0.06%	+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)	45.85 kB	+0.05%	+20 B 🔺
@sentry/browser (incl. Tracing, Replay)	79.95 kB	+0.03%	+23 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	69.67 kB	+0.03%	+20 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	84.62 kB	+0.03%	+22 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	96.87 kB	+0.02%	+17 B 🔺
@sentry/browser (incl. Feedback)	41.47 kB	+0.05%	+19 B 🔺
@sentry/browser (incl. sendFeedback)	29.48 kB	+0.06%	+17 B 🔺
@sentry/browser (incl. FeedbackAsync)	34.42 kB	+0.06%	+19 B 🔺
@sentry/react	26.5 kB	+0.07%	+17 B 🔺
@sentry/react (incl. Tracing)	43.72 kB	+0.04%	+16 B 🔺
@sentry/vue	29.24 kB	+0.07%	+18 B 🔺
@sentry/vue (incl. Tracing)	43.33 kB	+0.04%	+17 B 🔺
@sentry/svelte	24.81 kB	+0.08%	+19 B 🔺
CDN Bundle	27.1 kB	+0.06%	+16 B 🔺
CDN Bundle (incl. Tracing)	42.09 kB	+0.05%	+18 B 🔺
CDN Bundle (incl. Tracing, Replay)	78.61 kB	+0.03%	+17 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	84.09 kB	+0.02%	+16 B 🔺
CDN Bundle - uncompressed	79.52 kB	+0.09%	+65 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	124.9 kB	+0.06%	+66 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	240.93 kB	+0.03%	+66 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	253.69 kB	+0.03%	+66 B 🔺
@sentry/nextjs (client)	45.95 kB	+0.04%	+17 B 🔺
@sentry/sveltekit (client)	41.89 kB	+0.05%	+20 B 🔺
@sentry/node-core	51.17 kB	+0.03%	+15 B 🔺
@sentry/node	159.22 kB	+0.02%	+22 B 🔺
@sentry/node - without tracing	92.81 kB	+0.02%	+17 B 🔺
@sentry/aws-serverless	108.05 kB	+0.02%	+15 B 🔺

View base workflow run

[github-actions]

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	8,796	-	8,686	+1%
GET With Sentry	1,766	20%	1,689	+5%
GET With Sentry (error only)	5,950	68%	5,970	-0%
POST Baseline	1,195	-	1,210	-1%
POST With Sentry	593	50%	591	+0%
POST With Sentry (error only)	1,060	89%	1,064	-0%
MYSQL Baseline	3,306	-	3,309	-0%
MYSQL With Sentry	492	15%	496	-1%
MYSQL With Sentry (error only)	2,674	81%	2,701	-1%

View base workflow run

[Lms24]

Nice! I like the idea of offering a way to truncate but not do it by default!