feat(core): Re-add _experiments.enableLogs option #18299
Merged
+57 −2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The king is dead, long live the king
By popular demand (N=1 😄 ) we're re-introducing
_experiments.enableLogs. The option stays deprecated and maybe we can actually remove it or type it asundefinedin the next major to sunset it for good. Main motivation for re-adding: The flag was introduced in v9 while we already worked on v10 where we removed it again. Therefore, it had an unusually short lifespan. Some users didn't realize this when upgrading to v10 and were wondering where their logs went.Because this to me and a few others feels a bit wrong, I shall paraphrase our SDK development philosophy as to why we do it:
"We write the shitty code, so that others don't have to".