Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Nov 17, 2025

Next.js respects the PORT variable. If for some reason this is not sufficient for users we can ship a follow up with a config option, which I wanted to avoid in the first step.

Also did a small refactor of the fetching code.

closes #18135
closes https://linear.app/getsentry/issue/JS-1139/handle-the-case-where-users-define-a-different-portprotocol

@chargome chargome self-assigned this Nov 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,867 - 8,820 +1%
GET With Sentry 1,388 16% 1,402 -1%
GET With Sentry (error only) 6,161 69% 6,079 +1%
POST Baseline 1,215 - 1,214 +0%
POST With Sentry 524 43% 525 -0%
POST With Sentry (error only) 1,082 89% 1,065 +2%
MYSQL Baseline 3,331 - 3,369 -1%
MYSQL With Sentry 491 15% 496 -1%
MYSQL With Sentry (error only) 2,724 82% 2,757 -1%

View base workflow run

@chargome chargome requested a review from logaretm November 18, 2025 09:42
@chargome chargome merged commit 9482a02 into develop Nov 18, 2025
195 checks passed
@chargome chargome deleted the cg-next-dev-symbolication-port branch November 18, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants