Skip to content

Conversation

@andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 17, 2025

Contains backports of: #17979, #17665, #18056

Does not backport fixes for optional e2e test apps.

Comment on lines +319 to 320
'sentry.sveltekit.navigation.type': 'link',
'sentry.sveltekit.navigation.from': '/',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR assumes navigation.type changes from 'goto' to 'link' for redirects in SvelteKit 2.41.0 without evidence.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

The pull request modifies test expectations for navigation.type in the sveltekit-2-svelte-5 e2e tests, assuming that upgrading @sveltejs/kit from ^2.21.3 to 2.41.0 will change redirect navigation types from 'goto' to 'link'. This assumption lacks evidence (no changelog, issue, or documentation reference) and creates an inconsistency with the sveltekit-2 test suite, which expects 'goto' for the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the updated tests will fail, as programmatic redirects are documented to be 'goto'.

💡 Suggested Fix

Verify if SvelteKit 2.41.0 actually changes navigation.type for redirects from 'goto' to 'link'. Adjust test expectations accordingly or revert if no change is confirmed.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts#L319-L320 Potential issue: The pull request modifies test expectations for `navigation.type` in the `sveltekit-2-svelte-5` e2e tests, assuming that upgrading `@sveltejs/kit` from `^2.21.3` to `2.41.0` will change redirect navigation types from `'goto'` to `'link'`. This assumption lacks evidence (no changelog, issue, or documentation reference) and creates an inconsistency with the `sveltekit-2` test suite, which expects `'goto'` for the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the updated tests will fail, as programmatic redirects are documented to be `'goto'`. 

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2721742

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.79 kB added added
@sentry/browser - with treeshaking flags 22.36 kB added added
@sentry/browser (incl. Tracing) 39.66 kB added added
@sentry/browser (incl. Tracing, Replay) 77.93 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.71 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 82.63 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 94.76 kB added added
@sentry/browser (incl. Feedback) 40.48 kB added added
@sentry/browser (incl. sendFeedback) 28.48 kB added added
@sentry/browser (incl. FeedbackAsync) 33.37 kB added added
@sentry/react 25.55 kB added added
@sentry/react (incl. Tracing) 41.62 kB added added
@sentry/vue 28.24 kB added added
@sentry/vue (incl. Tracing) 41.45 kB added added
@sentry/svelte 23.81 kB added added
CDN Bundle 25.18 kB added added
CDN Bundle (incl. Tracing) 39.42 kB added added
CDN Bundle (incl. Tracing, Replay) 75.55 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 81.02 kB added added
CDN Bundle - uncompressed 73.45 kB added added
CDN Bundle (incl. Tracing) - uncompressed 116.86 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.75 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.56 kB added added
@sentry/nextjs (client) 43.66 kB added added
@sentry/sveltekit (client) 40.08 kB added added
@sentry/node 169.37 kB added added
@sentry/node - without tracing 100.51 kB added added
@sentry/aws-serverless 128.67 kB added added

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for going through all of these test fails! 🙏

@andreiborza andreiborza merged commit cb57c5b into v9 Nov 17, 2025
135 of 143 checks passed
@andreiborza andreiborza deleted the ab/fix-v9-e2e-tests branch November 17, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants