Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 12, 2025

This PR follows up from #18167:

  1. reduce bundle size slightly by optimizing setTag (+ adding some more tests around setTag(s))
  2. adjust the integration test that previously demonstrated a "bug" which we no longer classify as a bug but a "known spec violation" (until someone complains 😅). See fix(core): Ignore non-primitive values passed to setTag(s) #18167 (review) and fix(core): Ignore non-primitive values passed to setTag(s) #18167 (comment) for more context.
@Lms24 Lms24 assigned Lms24 and andreiborza and unassigned andreiborza Nov 12, 2025
@Lms24 Lms24 requested a review from andreiborza November 12, 2025 11:11
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.6 kB +0.02% +4 B 🔺
@sentry/browser - with treeshaking flags 23.09 kB +0.02% +3 B 🔺
@sentry/browser (incl. Tracing) 41.24 kB +0.01% +3 B 🔺
@sentry/browser (incl. Tracing, Profiling) 45.51 kB +0.01% +3 B 🔺
@sentry/browser (incl. Tracing, Replay) 79.71 kB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.38 kB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 84.4 kB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 96.57 kB -0.01% -1 B 🔽
@sentry/browser (incl. Feedback) 41.28 kB +0.02% +5 B 🔺
@sentry/browser (incl. sendFeedback) 29.27 kB +0.02% +4 B 🔺
@sentry/browser (incl. FeedbackAsync) 34.2 kB +0.02% +5 B 🔺
@sentry/react 26.29 kB +0.02% +4 B 🔺
@sentry/react (incl. Tracing) 43.2 kB - -
@sentry/vue 29.08 kB +0.02% +3 B 🔺
@sentry/vue (incl. Tracing) 43.01 kB +0.01% +4 B 🔺
@sentry/svelte 24.61 kB +0.02% +3 B 🔺
CDN Bundle 26.9 kB +0.02% +3 B 🔺
CDN Bundle (incl. Tracing) 41.79 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) 78.31 kB +0.01% +5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 83.78 kB +0.01% +5 B 🔺
CDN Bundle - uncompressed 78.84 kB -0.03% -17 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 123.94 kB -0.02% -17 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 239.98 kB -0.01% -17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 252.74 kB -0.01% -17 B 🔽
@sentry/nextjs (client) 45.32 kB +0.01% +2 B 🔺
@sentry/sveltekit (client) 41.62 kB +0.01% +4 B 🔺
@sentry/node-core 50.77 kB +0.01% +4 B 🔺
@sentry/node 157.85 kB - -
@sentry/node - without tracing 92.64 kB -0.01% -3 B 🔽
@sentry/aws-serverless 106.41 kB +0.01% +3 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,359 - 8,690 -4%
GET With Sentry 1,325 16% 1,397 -5%
GET With Sentry (error only) 6,038 72% 6,120 -1%
POST Baseline 1,183 - 1,213 -2%
POST With Sentry 521 44% 561 -7%
POST With Sentry (error only) 1,043 88% 1,072 -3%
MYSQL Baseline 3,199 - 3,363 -5%
MYSQL With Sentry 452 14% 482 -6%
MYSQL With Sentry (error only) 2,611 82% 2,713 -4%

View base workflow run

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@Lms24 Lms24 merged commit 679a02c into develop Nov 12, 2025
383 of 384 checks passed
@Lms24 Lms24 deleted the lms/ref-core-setTag-optimization branch November 12, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants