ref(core): Set span status internal_error instead of unknown_error #17909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from 3f632a7 to dcd9c05 Compare Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from dcd9c05 to 943783c Compare Lms24 requested review from a team, RulaKhaled, obostjancic, s1gr1d and stephanie-anderson and removed request for a team and stephanie-anderson 
s1gr1d approved these changes Oct 17, 2025
Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from 7484f01 to f26d8e8 Compare 
Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from f26d8e8 to 7cefd79 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR refactors almost all occurances of our SDK setting a span status of
unknown_errorto settinginternal_errorinstead. #17814 explains why we do this.I left a few selected occurances of
unknown_errorwhere I think it's fine to not change them. Worth noting, Relay already convertsunknown_errortointernal_error, so this is rather a "cleanup" and only has impact on self-hosted Sentry versions for now.closes #17814