feat(nuxt): Instrument server cache API #17886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
logaretm force-pushed the awad/js-1016-nuxtnitro-instrument-kv-storage-instrumenting-unstorage branch from 64e5814 to 42ef2c7 Compare logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from 09e73ad to 4f26f70 Compare 
s1gr1d reviewed Oct 9, 2025
| * Checks if the cache entry is a response cache entry. | ||
| */ | ||
| function isResponseCacheEntry(key: string, _: CacheEntry): _ is CacheEntry<ResponseCacheEntry & { status: number }> { | ||
| return key.startsWith('nitro:handlers:'); |
There was a problem hiding this comment.
Should this be checked with CACHED_FN_HANDLERS_RE here as well?
There was a problem hiding this comment.
Not here no, we want to be able to distinguish between cachedFunction and cachedEventHandler cached entries here, the regex detects if it is either.
The reason for the distinction is we want to apply more checks if it is a cached response entry since Nitro employs more checks in that case that would determine the cache validity.
logaretm force-pushed the awad/js-1016-nuxtnitro-instrument-kv-storage-instrumenting-unstorage branch from ab3ecc1 to d943f7d Compare 
logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from 1c23b89 to f2ad9e7 Compare This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds Nitro/Nuxt Cache API instrumentation by building upon the storage instrumentation in #17858 since both use
unstorageunder the hood.How it works
Nitro injects the cache storage on either
cache:or the root mount depending on user configuration, also in production thecachestorage is placed on the root mount unless the user configures it explicitly to redis or something else. We instrument both mount drivers to cover other cache use cases.I made sure to add e2e tests as well for
cachedEventListnerandcachedFunctioncalls which are the main ways to use the Cache API.This PR depends on the storage PR #17858.