feat(logs): Add internal replay_is_buffering flag #17752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chargome commented Sep 24, 2025
Comment on lines +155 to +157
| Integration & { | ||
| getReplayId: (onlyIfSampled?: boolean) => string; | ||
| getRecordingMode: () => 'session' | 'buffer' | undefined; |
Member Author
There was a problem hiding this comment.
@AbhiPrasad I kept the inlined types here, I assume we have no access to the replay types in core?
Member
There was a problem hiding this comment.
We could extract the types into core to make this a more "public" API, it also helps to keep this consistent. I'd just do it in another PR though.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
billyvg approved these changes Sep 25, 2025
Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
chargome force-pushed the cg-replay-add-buffer-attribute branch from 4fb9c51 to 2238e52 Compare This was referenced Sep 29, 2025
This was referenced Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a flag
replay_is_bufferingfor identifying cases where the replayId is attached but the replay itself might never arrive in Sentry.ref #17676