feat(core): better cause data extraction #17375
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).closes #15142
When using
ExtraErrorDataIntegration,error.causeserializes with.toString()which is not very informative considering the purpose of the integration.This PR improves
error.causehandling inExtraErrorDataIntegrationby recursing the_extractErrorDatafor a single cause depth. To match the outer structure and provide more information the cause object is wrapped with[name].The
.toString()serialized data is gone now but if we are usingLinkedErrorsIntegrationthe string message will still be visible.Since these changes are useful enough, I think more detailed specifications (like cause recursion) could be addressed by future PRs - open to suggestions.
Before:
After: