Skip to content

Include version in dependency auto install messages #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Include version in dependency auto install messages #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Add upload functionality for size analysis ([#915](https://github.com/getsentry/sentry-android-gradle-plugin/pull/915))
- Add VCS info extension for build uploads with customizable version control metadata ([#969](https://github.com/getsentry/sentry-android-gradle-plugin/pull/969))
- Include version in logs if auto install refuses to install a dependency ([#979](https://github.com/getsentry/sentry-android-gradle-plugin/pull/979))

### Fixes

Expand Down
10 changes: 5 additions & 5 deletions plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AbstractInstallStrategy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ abstract class AbstractInstallStrategy : ComponentMetadataRule {
parseVersion(context.details.id.version)?.let { thirdPartySemVersion ->
if (thirdPartySemVersion < it) {
logger.info {
"$sentryModuleId won't be installed because the current version is " +
"$sentryModuleId won't be installed because the current version ($thirdPartySemVersion) is " +
"lower than the minimum supported version ($it)"
}
return
Expand All @@ -43,8 +43,8 @@ abstract class AbstractInstallStrategy : ComponentMetadataRule {
parseVersion(context.details.id.version)?.let { thirdPartySemVersion ->
if (thirdPartySemVersion > it) {
logger.info {
"$sentryModuleId won't be installed because the current version is " +
"higher than the maximum supported version ($it)"
"$sentryModuleId won't be installed because the current version ($thirdPartySemVersion) " +
"is higher than the maximum supported version ($it)"
}
return
}
Expand All @@ -57,7 +57,7 @@ abstract class AbstractInstallStrategy : ComponentMetadataRule {
if (sentrySemVersion < minSupportedSentryVersion) {
logger.warn {
"$sentryModuleId won't be installed because the current sentry version " +
"is lower than the minimum supported sentry version " +
"($sentrySemVersion) is lower than the minimum supported sentry version " +
"($minSupportedSentryVersion)"
}
return
Expand All @@ -78,7 +78,7 @@ abstract class AbstractInstallStrategy : ComponentMetadataRule {
if (sentrySemVersion > maxSupportedSentryVersion) {
logger.debug {
"$sentryModuleId won't be installed because the current sentry version " +
"is higher than the maximum supported sentry version " +
"($sentrySemVersion) is higher than the maximum supported sentry version " +
"($maxSupportedSentryVersion)"
}
return
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/kotlin/io/sentry/android/gradle/autoinstall/compose/ComposeInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class ComposeInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-compose-android won't be installed because the current " +
"version is lower than the minimum supported version (1.0.0)"
"version (0.9.0) is lower than the minimum supported version (1.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion .../test/kotlin/io/sentry/android/gradle/autoinstall/graphql/Graphql22InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class Graphql22InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-graphql-22 won't be installed because the current " +
"version is lower than the minimum supported version (22.0.0)"
"version (21.9.0) is lower than the minimum supported version (22.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/kotlin/io/sentry/android/gradle/autoinstall/graphql/GraphqlInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class GraphqlInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-graphql won't be installed because the current " +
"version is higher than the maximum supported version (21.9999.9999)"
"version (22.1.0) is higher than the maximum supported version (21.9999.9999)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion ...kotlin/io/sentry/android/gradle/autoinstall/kotlin/KotlinExtensionsInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class KotlinExtensionsInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-kotlin-extensions won't be installed because the current " +
"version is lower than the minimum supported version (1.6.1)"
"version (1.6.0) is lower than the minimum supported version (1.6.1)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion .../src/test/kotlin/io/sentry/android/gradle/autoinstall/log4j2/Log4j2InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Log4j2InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-log4j2 won't be installed because the current " +
"version is lower than the minimum supported version (2.0.0)"
"version (1.0.0) is lower than the minimum supported version (2.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/kotlin/io/sentry/android/gradle/autoinstall/logback/LogbackInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class LogbackInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-logback won't be installed because the current " +
"version is lower than the minimum supported version (1.0.0)"
"version (0.0.1) is lower than the minimum supported version (1.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
4 changes: 2 additions & 2 deletions ...st/kotlin/io/sentry/android/gradle/autoinstall/okhttp/AndroidOkHttpInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class AndroidOkHttpInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-android-okhttp won't be installed because the current " +
"version is lower than the minimum supported version (3.13.0)"
"version (3.11.0) is lower than the minimum supported version (3.13.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand All @@ -80,7 +80,7 @@ class AndroidOkHttpInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-android-okhttp won't be installed because the current " +
"sentry version is higher than the maximum supported sentry version (6.9999.9999)"
"sentry version (7.0.0) is higher than the maximum supported sentry version (6.9999.9999)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
4 changes: 2 additions & 2 deletions .../src/test/kotlin/io/sentry/android/gradle/autoinstall/okhttp/OkHttpInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class OkHttpInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-okhttp won't be installed because the current " +
"version is lower than the minimum supported version (3.13.0)"
"version (3.11.0) is lower than the minimum supported version (3.13.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand All @@ -80,7 +80,7 @@ class OkHttpInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-okhttp won't be installed because the current sentry " +
"version is lower than the minimum supported sentry version (7.0.0)"
"version (6.33.0) is lower than the minimum supported sentry version (7.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
4 changes: 2 additions & 2 deletions ...src/test/kotlin/io/sentry/android/gradle/autoinstall/spring/Spring5InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Spring5InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring won't be installed because the current " +
"version is lower than the minimum supported version (5.1.2)"
"version (5.1.1) is lower than the minimum supported version (5.1.2)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand All @@ -76,7 +76,7 @@ class Spring5InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring won't be installed because the current " +
"version is higher than the maximum supported version (5.9999.9999)"
"version (6.0.0) is higher than the maximum supported version (5.9999.9999)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion ...src/test/kotlin/io/sentry/android/gradle/autoinstall/spring/Spring6InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Spring6InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring-jakarta won't be installed because the current " +
"version is lower than the minimum supported version (6.0.0)"
"version (5.7.4) is lower than the minimum supported version (6.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
4 changes: 2 additions & 2 deletions ...test/kotlin/io/sentry/android/gradle/autoinstall/spring/SpringBoot2InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SpringBoot2InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring-boot won't be installed because the current " +
"version is lower than the minimum supported version (2.1.0)"
"version (2.0.0) is lower than the minimum supported version (2.1.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand All @@ -76,7 +76,7 @@ class SpringBoot2InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring-boot won't be installed because the current " +
"version is higher than the maximum supported version (2.9999.9999)"
"version (3.0.0) is higher than the maximum supported version (2.9999.9999)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion ...test/kotlin/io/sentry/android/gradle/autoinstall/spring/SpringBoot3InstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SpringBoot3InstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-spring-boot-jakarta won't be installed because the " +
"current version is lower than the minimum supported version (3.0.0)"
"current version (2.7.13) is lower than the minimum supported version (3.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion .../src/test/kotlin/io/sentry/android/gradle/autoinstall/sqlite/SqliteInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SqliteInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-android-sqlite won't be installed because the current " +
"version is lower than the minimum supported version (2.0.0)"
"version (1.0.0) is lower than the minimum supported version (2.0.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
2 changes: 1 addition & 1 deletion .../src/test/kotlin/io/sentry/android/gradle/autoinstall/timber/TimberInstallStrategyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class TimberInstallStrategyTest {
assertTrue {
fixture.logger.capturedMessage ==
"[sentry] sentry-android-timber won't be installed because the current " +
"version is lower than the minimum supported version (4.6.0)"
"version (4.5.0) is lower than the minimum supported version (4.6.0)"
}
verify(fixture.metadataDetails, never()).allVariants(any())
}
Expand Down
Loading