Fix sentry-cli not being extracted prior to task execution #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markushi requested review from adinauer, romtsn and stefanosiano as code owners markushi changed the title markushi changed the title 
markushi commented Apr 12, 2024
| | ||
| internal fun searchCliInResources(resourcePath: String): String? { | ||
| val resourceURL = javaClass.getResource(resourcePath) | ||
| val resourceFile = resourceURL?.let { File(it.file) } |
Member Author
There was a problem hiding this comment.
I'm really not sure why this was done this way 😅 Shouldn't it be fine to just null check the resourceURL?
Member
There was a problem hiding this comment.
yeah I also don't know, null check should be fine I guess 👍
romtsn reviewed Apr 15, 2024
plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt Outdated Show resolved Hide resolved
romtsn reviewed Apr 15, 2024
plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryCliExecTask.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #686
Created a base task for all our sentry-cli based tasks.
During task execution the cli is then extracted if the computed path does not exist.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps