Skip to content

Conversation

@markushi
Copy link
Member

@markushi markushi commented Mar 25, 2024

📜 Description

Based on the task graph for R8/DG, mergeDex<Variant> is the closest to minify<Variant>WithR8.

  1. hooked ProGuard UUID gen task to the minify/mergeDex tasks
  2. hooked UUID upload to assemble task (same as source context)

💡 Motivation and Context

Fixes #679

Not sure if we still need transformClassesAndResourcesWithProguardTransformFor*!?

💚 How did you test it?

Manual testing with example app.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi markushi merged commit 2ea612f into main Mar 25, 2024
@markushi markushi deleted the fix/dexguard-circular-dependency branch March 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants