Add automatic subscription reconnection for network disconnections #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Implements automatic token refresh to prevent authentication errors in long-running apps. Tokens are proactively refreshed 60 seconds before expiration. Features: - TokenRefreshManager monitors JWT expiration and auto-refreshes - AuthProviderError enum for standardized auth error handling - Default AuthProvider.refreshToken(from:) throws refreshNotSupported - Providers can opt-in by implementing refreshToken(from:) - Auto-logout on refresh failure for better UX - Uses Timer instead of Task.sleep for iOS Simulator reliability Changes: - Add JWTDecoder helper for extracting token expiration - Add TokenRefreshManager class for refresh orchestration - Extend AuthProvider protocol with optional refreshToken method - Add comprehensive tests for refresh scenarios - Update README with token refresh documentation - Add CHANGELOG documenting breaking/non-breaking changes Non-breaking: Existing AuthProviders continue to work without changes. Providers that don't support refresh will use default implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Implements automatic resubscription of queries when network connectivity is restored, fixing the infinite loading spinner issue after network interruptions. Features: - NetworkMonitor using Network.framework for connectivity detection (iOS 12.0+) - Automatic subscription tracking in ConvexClient - Subscriptions automatically reestablish when network reconnects - Manual reconnect() API for app lifecycle integration - Works seamlessly with WiFi↔Cellular, airplane mode, Mac sleep/wake - Thread-safe subscription tracking with NSLock Changes: - Add NetworkMonitor class for network path monitoring - Add subscription tracking to ConvexClient (UUID-based) - Extend subscribe() to register and track active subscriptions - Implement resubscribeAll() for automatic reconnection - Add public reconnect() method for manual control - NetworkMonitor disabled for test clients to avoid test flakiness - Add comprehensive tests for reconnection scenarios - Update README with reconnection documentation - Update CHANGELOG with detailed feature description Fixes: - Infinite loading spinner after Mac laptop sleep/wake - Subscriptions not updating after WiFi disconnect/reconnect - Data not refreshing after network state changes - Missing reconnection handling reported by Discord users 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
| Similar to my thoughts on #6, closing this PR. |
| I'll note that for this functionality in particular, I would advocate for pushing the logic further down the stack into the Rust layer so any clients built off of it would benefit. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Implements automatic resubscription of queries when network connectivity is restored, fixing the infinite loading spinner issue after network interruptions.
Features
Changes
API Documentation
Added comprehensive DocC documentation for the new
reconnect()public API:Testing
Fixes
Dependencies
This PR builds on top of #6 (JWT Token Refresh). It can be reviewed independently but should be merged after #6.
🤖 Generated with Claude Code