Better encoding #3
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Better support for optionals, arrays and dictionaries
Problem
The current ConvexMobile encoding implementation has limited support for common Swift collection types, leading to compilation errors when trying to use arrays and dictionaries with ConvexEncodable values.
Issue encountered:
When attempting to encode a
[String]array, the compiler throws an error:Example that fails with the current implementation:
The workaround required manual casting:
Solution
This PR enhances the ConvexEncodable protocol support by adding proper extensions for:
Array<Element: ConvexEncodable>replaces the specific[ConvexEncodable?]extensionDictionary<String, ConvexEncodable>replaces the specific[String: ConvexEncodable?]extensionOptional<Wrapped: ConvexEncodable>provides clean null encoding.sorted()call for better performanceAfter this PR
The problematic example now works seamlessly:
The changes are backward compatible.
This improvement makes ConvexMobile more intuitive to use with standard Swift collection types while maintaining the same encoding behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.