Add Async Iterator Support to Query Subscription #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Toubat wants to merge 1 commit into get-convex:main from Toubat:main

Contributor

Toubat commented Oct 4, 2024

Allows developer to async iterate on query subscription:

client = ConvexClient('https://example-xxx-xxx.convex.cloud') qs = client.subscribe("messages:latestMessage") async for part in qs: print(part)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

add async iterator

1e47ea7

nipunn1313 requested a review from thomasballinger

October 4, 2024 23:24

Toubat changed the title ~~Add Async Iterator to Query Subscription~~ Add Async Iterator Support to Query Subscription

Contributor Author

Toubat commented Oct 31, 2024

Hi @thomasballinger! Just checking in to see if there’s any update on the status of this PR. Thanks!

Collaborator

thomasballinger commented Oct 31, 2024

Hey @Toubat, sorry for the delay here! No concerns here, @anjanbharadwaj even wrote something like this when he was implementing this and I pulled it just to start the API off smaller.

Since this is pretty stable but we're still in 0.6.0, no concerns, let's see how it goes.

thomasballinger approved these changes

View reviewed changes

Collaborator

thomasballinger commented Oct 31, 2024

@Toubat I'll we'll get a release out by next week!

Collaborator

thomasballinger commented Oct 31, 2024

@Toubat this is in 76fb9aa, will close when we get a release out.

thomasballinger closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment