Dual package #89
Closed
Dual package #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Wildcard exports might be being used, but since exports: doesn't point to the right files for now this seems low-risk (see https://arethetypeswrong.github.io/?p=convex-helpers%400.1.27)
Dual build ESM/CJS
| } | ||
| } | ||
| | ||
| checkPackageJsonExports(); |
Collaborator
There was a problem hiding this comment.
is this supposed to also write the exports? I only see the verification
Contributor Author
There was a problem hiding this comment.
yeah just verification, to avoid the checked in package.json differing from what's used, e.g. accidentally publishing changes not checked in to the repo
Collaborator
| Closing, since esm seems fine for us for now |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Compile ESM and CJS builds and types and use exports to point to them.
This resolves the warnings here and makes ts-jest work in https://github.com/get-convex/convex-chess/pull/19/files without adding the exception not to compile these files.
I'm not sure this needs to be a dual package though. If we could get away with ESM-only the build would be simpler. That's the way we should recommend developers build things in Convex.