Skip to content

Allow flatMap streams without index fields to merge #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow flatMap streams without index fields to merge #719

wants to merge 4 commits into from

Conversation

@ianmacartney
Copy link
Collaborator

@ianmacartney ianmacartney commented Aug 5, 2025 •
edited
Loading

Summary

  • allow flatMap to skip index field normalization when no mapped fields are provided
  • relax FlatMapStream index field checks for empty mapped fields
  • add regression test reproducing merging of flat-mapped and direct streams

Fixes #690

Testing

  • npm test

https://chatgpt.com/codex/tasks/task_b_68927274cefc832aa5721d4adfe91819

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 5, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/convex-helpers@719

commit: ce0b700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex

2 participants

@ianmacartney