Convert claude to use .md instead of .xml #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
runner/models/anthropic_codegen.py Outdated
Comment on lines 36 to 40
| {"role": "assistant", "content": [{"type": "text", "text": "<analysis>"}]}, | ||
| # {"role": "assistant", "content": [{"type": "text", "text": "<analysis>"}]}, |
Collaborator Author
There was a problem hiding this comment.
i meant to delete this file
Comment on lines 20 to 21
| with open("dist/anthropic_convex_rules.txt", "w") as f: | ||
| f.write(build_anthropic_rules()) | ||
| | ||
| with open("dist/openai_convex_rules.txt", "w") as f: | ||
| f.write(build_openai_rules()) | ||
| | ||
| # Generate MDC files with frontmatter | ||
| with open("dist/anthropic_convex_rules.mdc", "w") as f: | ||
| f.write(MDC_FRONTMATTER) | ||
| f.write(build_anthropic_rules()) | ||
| | ||
| with open("dist/openai_convex_rules.mdc", "w") as f: | ||
| | ||
| # Generate rules using a very specific filename here to make it clear for AI usage what this is. | ||
| with open("dist/convex_rules.txt", "w") as f: | ||
| f.write(build_release_rules()) | ||
| | ||
| with open("dist/convex_rules.mdc", "w") as f: |
Contributor
There was a problem hiding this comment.
does this mean deep links to the existing release will break? maybe we should keep pushing to both in case we decide to have different rules for each going forward
Collaborator Author
There was a problem hiding this comment.
do we have existing deeplinks to these somewhere?
Collaborator Author
There was a problem hiding this comment.
i'm happy to just continue with the old format if there are some existing links we don't wanna break
ianmacartney approved these changes Feb 15, 2025
Contributor
ianmacartney left a comment
ianmacartney left a comment There was a problem hiding this comment.
I'm ok with this, modulo changing the release names.
I do wonder if we'll be splitting the logic out again in the future, and if so what of this we'll need to revive from the dead, but that'd be easier to reintroduce than keep around
Collaborator Author
the hope is that we don't have to split the logic out again. all the models besides |
Contributor
| yeah let's make it additive. Mike made these (that we can edit) but also maybe has put direct links in repos / videos? https://convex.link/openai_convex_rules.txt https://convex.link/anthropic_convex_rules.mdc https://convex.link/openai_convex_rules.mdc …On Fri, Feb 14, 2025 at 5:38 PM Jordan Hunt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build_release.py <#52 (comment)> : > - with open("dist/anthropic_convex_rules.txt", "w") as f: - f.write(build_anthropic_rules()) - - with open("dist/openai_convex_rules.txt", "w") as f: - f.write(build_openai_rules()) - - # Generate MDC files with frontmatter - with open("dist/anthropic_convex_rules.mdc", "w") as f: - f.write(MDC_FRONTMATTER) - f.write(build_anthropic_rules()) - - with open("dist/openai_convex_rules.mdc", "w") as f: + + # Generate rules using a very specific filename here to make it clear for AI usage what this is. + with open("dist/convex_rules.txt", "w") as f: + f.write(build_release_rules()) + + with open("dist/convex_rules.mdc", "w") as f: i'm happy to just continue with the old format if there are some existing links we don't wanna break — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACZQW6JPBWWZWBEKUDFT2T2P2K77AVCNFSM6AAAAABXDSQHCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJZGIYTONBWGE> . You are receiving this because your review was requested.Message ID: ***@***.***> |
Contributor
| editable in dub.co …On Fri, Feb 14, 2025 at 5:40 PM Ian Macartney ***@***.***> wrote: yeah let's make it additive. Mike made these (that we can edit) but also maybe has put direct links in repos / videos? https://convex.link/openai_convex_rules.txt https://convex.link/anthropic_convex_rules.mdc https://convex.link/openai_convex_rules.mdc On Fri, Feb 14, 2025 at 5:38 PM Jordan Hunt ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In build_release.py > <#52 (comment)> > : > > > - with open("dist/anthropic_convex_rules.txt", "w") as f: > - f.write(build_anthropic_rules()) > - > - with open("dist/openai_convex_rules.txt", "w") as f: > - f.write(build_openai_rules()) > - > - # Generate MDC files with frontmatter > - with open("dist/anthropic_convex_rules.mdc", "w") as f: > - f.write(MDC_FRONTMATTER) > - f.write(build_anthropic_rules()) > - > - with open("dist/openai_convex_rules.mdc", "w") as f: > + > + # Generate rules using a very specific filename here to make it clear for AI usage what this is. > + with open("dist/convex_rules.txt", "w") as f: > + f.write(build_release_rules()) > + > + with open("dist/convex_rules.mdc", "w") as f: > > i'm happy to just continue with the old format if there are some existing > links we don't wanna break > > — > Reply to this email directly, view it on GitHub > <#52 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACZQW6JPBWWZWBEKUDFT2T2P2K77AVCNFSM6AAAAABXDSQHCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJZGIYTONBWGE> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This means that all of our evals will use the same format! Tested that this works, and the performance of
claudeis very similar.