Make docker.sock hunting optional #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
patrickdung added a commit to patrickdung/amicontained-build that referenced this pull request Jan 27, 2022
only build arm64 reverted this commit genuinetools#15 and functionality is not same as amd64 2) make docker.sock hunting optional include genuinetools#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
docker.sockhunting often hangs or takes a very long time depending on the runtime and what sockets are in the container/host.This PR makes it optional, default off (this is a behaviour change).
I tried to make default
truebut then I could find how to have the CLI flag turn it off, I don't understandpkg/cliproperly, or perhaps its not possible.After this PR:
amicontained -sto look for docker.sock (the old behaviour).amicontainedto skip looking for docker.sock