- Notifications
You must be signed in to change notification settings - Fork 53
Improve action button icons with SF Symbols #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Use qrcode icon for receive button - Use dollarsign icon for buy button - Use arrow.trianglehead.2.clockwise icon for swap button - Add qrCodePlain and arrowTrianglehead2Clockwise system images
- Use paperplane icon for send button - Use qrcode icon for receive button - Use dollarsign icon for buy button - Use arrow.trianglehead.2.clockwise icon for swap button - Add new system images: qrCode, arrowSwap, paperplane - Rename qrCode to qrCodeViewfinder for existing scan functionality
Summary of ChangesHello @DRadmir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience by updating various action button icons across the application to leverage more intuitive and modern SF Symbols. The changes aim to provide clearer visual cues for core functionalities like sending, receiving, buying, and swapping, while also refining the usage of QR code-related icons for better distinction between scanning and general display, ultimately enhancing the overall aesthetic and usability of the interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates several action button icons to use more appropriate SF Symbols, which enhances the user experience and consistency across the app. The changes are well-implemented, including renaming qrCode
to qrCodeViewfinder
for better clarity in scanning contexts and introducing new system images for primary actions. My review includes one suggestion to extend this improvement to other related actions for complete consistency.
…ove-action-button-icons
Updates icon size to 20pt with medium weight, changes button shape from cornerRadius to Circle(), and simplifies frame modifier for cleaner geometry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ove-action-button-icons
Summary
Update action button icons with SF Symbols
Changes
paperplane
qrcode
dollarsign
arrow.trianglehead.2.clockwise
Screenshots
Fixes #1246