Refactor ConfirmTransferScene to use sectioned list #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replaces legacy transaction list with a sectioned ListSectionView in ConfirmTransferScene. Introduces ConfirmTransferSection, ConfirmTransferItem, and related view models for header, app, and sender items. Updates ConfirmTransferSceneViewModel to provide sectioned data and item models. Cleans up TransferDataViewModel by removing app-related properties now handled by dedicated view models. Adds convenience initializer to ListItemImageView.
Introduces dedicated view models for ConfirmTransfer items (network, recipient, memo, network fee, error, swap details) and updates ConfirmTransferScene and related types to use them. Removes legacy code and centralizes item model logic, improving modularity and maintainability. Also updates ListItemImageView and ListSectionView initializers for consistency.
Moved memo formatting and list item model logic from individual view models and the deleted MemoListItemView to a new MemoViewModel in PrimitivesComponents. Updated TransactionMemoViewModel and ConfirmTransferMemoViewModel to use MemoViewModel for memo display. Cleaned up redundant code and improved consistency in memo handling.
Replaces direct construction of SwapDetailsViewModel with ConfirmTransferSwapDetailsViewModel in ConfirmTransferSceneViewModel. Moves swap details logic into a computed property for better encapsulation and maintainability.
Expanded and refactored tests in ConfirmTransferSceneViewModelTests to verify item model outputs for all relevant cases, improving coverage and clarity. Removed redundant memo visibility test from TransferDataViewModelTests.
Renamed all ConfirmTransfer*ViewModel files and types to more concise names (e.g., ConfirmAppViewModel, ConfirmErrorViewModel, etc.) for improved clarity and consistency. Updated all references in ConfirmTransferSceneViewModel and related tests to use the new names.
Introduces the TransferTestKit target with mock helpers for testing, updates Package.swift to include TransferTestKit, and adds comprehensive unit tests for Confirm* and TransactionInputViewModel-related ViewModels. Also refactors TransactionInputViewModel for public access and corrects asset selection logic. Updates PrimitivesTestKit mocks and adds SwapData mock helper.
Fixed To Should not be shown for empty transaction, added tests
gemcoder21 reviewed Oct 6, 2025
| } | ||
| | ||
| @Test | ||
| func transfer() { |
There was a problem hiding this comment.
useless unit tests transfer, deposit ...
gemcoder21 reviewed Oct 6, 2025
| } | ||
| | ||
| @Test | ||
| func swap() { |
gemcoder21 approved these changes Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
ConfirmTransferSceneto use a sectioned list architecture with dedicated view models for each component, improving modularity, testability, and maintainability.Changes
Architecture Improvements
ListSectionProvideablepattern: Replaced the legacy transaction list withListSectionViewfor better organizationConfirmHeaderViewModel- Transfer header displayConfirmAppViewModel- WalletConnect app informationConfirmSenderViewModel- Sender account detailsConfirmNetworkViewModel- Network informationConfirmRecipientViewModel- Recipient address handlingConfirmMemoViewModel- Memo field logicConfirmSwapDetailsViewModel- Swap-specific detailsConfirmNetworkFeeViewModel- Network fee display and selectionConfirmErrorViewModel- Error state handlingCode Quality
ConfirmTransferSceneViewModelcomplexity by extracting component-specific logicTransferDataViewModelMemoViewModelused by both Transfer and Transactions featuresConfirmTransferSectionandConfirmTransferItemenums for type-safe section/item modelingTesting
TransferTestKittarget: New testing utilities packageBlockExplorerLink,TransactionData, andTransactionInputViewModelUI/UX
Files Changed
Test Plan
🤖 Generated with Claude Code
closes #1145
closes #1216