- Notifications
You must be signed in to change notification settings - Fork 11
feat(docs): setup vitepress and github pages deployment #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Install vitepress and vue as dev dependencies. - Add docs/.vitepress/config.mts configuration. - Add docs:dev, docs:build, docs:preview scripts. - Update .gitignore for vitepress artifacts.
- Add .github/workflows/deploy-docs.yml to deploy docs to GitHub Pages on push to main.
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive documentation system using VitePress, complete with automated deployment to GitHub Pages. This initiative significantly enhances the project's ability to provide clear and accessible documentation, streamlining the process for both developers and users to understand and interact with the "Gemini Workspace Extension." It directly addresses and resolves issue #93. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces VitePress for documentation, including configuration, dependencies, and npm scripts. While this is a good start, there are two key issues. First, the VitePress configuration is missing the base property, which is essential for deploying to GitHub Pages; I've left a specific comment with a suggestion. Second, and more critically, the GitHub Actions workflow for deployment mentioned in the pull request title and description is missing from the changes. Without this workflow, the automated deployment to GitHub Pages will not be set up.
- Set base to '/workspace/' in vitepress config to ensure correct asset paths on GitHub Pages.
- Updates `package-lock.json` to include VitePress dependencies. - Restores and stages `docs/.vitepress` configuration files.
- Removes accidentally committed VitePress cache files from `docs/.vitepress/vitepress_config`. - Updates `eslint.config.js` to ignore `docs/.vitepress/cache` and `docs/.vitepress/dist`.
- Modifies the `clean` script in `package.json` to remove VitePress cache (`docs/.vitepress/cache`) and build output (`docs/.vitepress/dist`) directories.
Sets up VitePress for documentation and adds a GitHub Actions workflow to deploy to GitHub Pages.
Resolves #93