Skip to content

Incorporated today's feedback #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 7, 2023
Merged

Incorporated today's feedback #4

merged 14 commits into from
Jun 7, 2023

Conversation

@helloparthshah
Copy link
Contributor

@helloparthshah helloparthshah commented Jun 2, 2023 •
edited
Loading

  • Rewrote the workflow to use specific versions
  • Using actions/deploy-pages@v2 to deploy to gh-pages
  • No need for a different branch, the built website is uploaded as an artifact now.
  • Not relying on any external CDNs. Added fonts and CSS files locally.
  • Updated the config for basePath to behave correctly in local and testing environments. In the testing/development environment, the basePath is set to an empty string and for the production/build environment it uses the basePath manually set for it.
  • Updated the documentation to reflect the changes we made as well as the discussion this morning
  • Added tests.yml to run the tests on PR
helloparthshah and others added 14 commits June 2, 2023 14:45
@helloparthshah @Harshil2107 @kunpai
Updated documentation to add more details for configs
c20c0c3 
Updated to not depend upon external cdns Co-authored-by: Harshil2107 <harshilp2107@gmail.com> Co-authored-by: kunpai <kunpai@ucdavis.edu>
@helloparthshah @Harshil2107 @kunpai
Updated the workflow to use specific versions
ad92ee0 
Co-authored-by: Harshil2107 <harshilp2107@gmail.com> Co-authored-by: kunpai <kunpai@ucdavis.edu>
@helloparthshah
Create nextjs.yml
4bffb80
@helloparthshah @Harshil2107 @kunpai
Updated workflow
a66416e 
Co-authored-by: Harshil2107 <harshilp2107@gmail.com> Co-authored-by: kunpai <kunpai@ucdavis.edu>
@helloparthshah @Harshil2107 @kunpai
Fixes to the workflow
492e8a6 
Co-authored-by: Harshil2107 <harshilp2107@gmail.com> Co-authored-by: kunpai <kunpai@ucdavis.edu>
@helloparthshah
Testing if building website works
aacb88e
@helloparthshah
Merge branch 'gem5:main' into main
4d17ae5
@helloparthshah
Updated workflow
681f24c
@helloparthshah
Fixed cypress tests
a5d13dc
@helloparthshah
Removed all external dependancies
900b9d6
@helloparthshah
Renamed workflow file
18c1b8b
@helloparthshah @kunpai
Updated documentation
970e5a6 
Co-authored-by: kunpai <kunpai@ucdavis.edu>
@helloparthshah
Added tests.yml to run on pull requests
882eb88
@helloparthshah
Fixed a small bug with search queries
06fdc98
@BobbyRBruce BobbyRBruce merged commit 5f9816d into gem5:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@helloparthshah @BobbyRBruce