Updated internal workloads loading to allow support for suites. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| LGTM |
Harshil2107 approved these changes Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Suites currently are reusing the workloads field which was being used for internal reverse mapping for the website. This PR updates the internal field to be workloads_mapping in order to keep support for displaying suites.
This PR also updates the logic for displaying tabs with nested data structures (list of objects) to be displayed as JSON instead of list of strings.
Ref:
Before: http://resources.gem5.org/resources/npb-benchmark-suite/raw?database=gem5-resources&version=1.0.0
After: http://projects.helloparthshah.me/gem5-resources-website/resources/npb-benchmark-suite/raw?database=gem5-resources&version=1.0.0