Very small updates... #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits September 20, 2016 16:19
Updated the script to now look for the release macOS Sierra installer, instead of the 10.12 Developer Preview!
Adding in a simple description of how to increase the video resolution of the VM for macOS.
KarlAmort reviewed Oct 21, 2016
There was a problem hiding this comment.
Just a short comment as an interested user: I had not heard of GOP and UGA, and these instructions just turned them from unknown unknowns to known unknowns. Unless there are situations where I should choose UGA, it may be better to change these instructions two a three-step process, i. e.:
- Shut down the VM
- Run VBoxManage [...]
[table of mappings id -> resolution] - Boot VM
added 3 commits October 21, 2016 21:30
Updating the realm discussion about larger screen size for the macOS VM instance, based on comments in the PR request.
Fixed a typo, and simplified the text a bit.
| Thanks for the comments. I've simplified the video discussion to remove the extraneous comments about video subsystems, which as you pointed out is not pertinent to setting the VM to the resolution you want. |
geerlingguy added a commit that referenced this pull request Oct 22, 2016
| Thanks for the notes! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updated the Readme.md file to add a discussion about how you can change the default screen resolution for the VM. (Very handy to have this in one place.) Also updated the script for a typo. (I see you already got the update for the installer name.) :)