Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Conversation

@oxyc
Copy link
Collaborator

@oxyc oxyc commented May 27, 2021

No description provided.

@oxyc oxyc mentioned this pull request May 27, 2021
@geerlingguy geerlingguy self-requested a review May 27, 2021 04:32
Copy link
Owner

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but didn't thoroughly test. I'm hoping someone that did hit this problem can test completely.

@kekkis
Copy link

kekkis commented May 28, 2021

FWIW, with this change in place, I ran a vagrant up successfully both using Homebrew's latest Ansible:

ansible: stable 4.0.0 (bottled), HEAD 

And Homebrew's ansible@2.9:

ansible@2.9: stable 2.9.22 (bottled) [keg-only] 
@oxyc
Copy link
Collaborator Author

oxyc commented May 28, 2021

ansible@2.9: stable 2.9.22 (bottled) [keg-only]

With this it actually detectes 2.9 and not 2.9.22 but maybe that's fine

@oxyc
Copy link
Collaborator Author

oxyc commented May 28, 2021

Could always make it: /\s(#{Gem::Version::VERSION_PATTERN})/

ansible 2.1.3 # works ansible 2.1.3-beta # works ansible [core 2.13] # works ansible: stable 4.0.0 (bottled), HEAD # works ansible@2.9: stable 2.9.22 (bottled) [keg-only] # works ansible 3 [core 3.13] # would not work
@kekkis
Copy link

kekkis commented May 28, 2021

@oxyc These snippets were from brew info, not from ansible --version. The ansible --version outputs are, of course:

ansible@2.9

ansible --version ansible 2.9.22 config file = None configured module search path = ['/Users/kekkis/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /usr/local/Cellar/ansible@2.9/2.9.22/libexec/lib/python3.9/site-packages/ansible executable location = /usr/local/opt/ansible@2.9/bin/ansible python version = 3.9.5 (default, May 4 2021, 03:33:11) [Clang 12.0.0 (clang-1200.0.32.29)] 

ansible 4.0.0:

ansible [core 2.11.0] config file = None configured module search path = ['/Users/kekkis/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /usr/local/Cellar/ansible/4.0.0/libexec/lib/python3.9/site-packages/ansible ansible collection location = /Users/kekkis/.ansible/collections:/usr/share/ansible/collections executable location = /usr/local/bin/ansible python version = 3.9.5 (default, May 4 2021, 03:33:11) [Clang 12.0.0 (clang-1200.0.32.29)] jinja version = 3.0.1 libyaml = True 
@geerlingguy geerlingguy merged commit 788e337 into geerlingguy:master May 28, 2021
@geerlingguy geerlingguy mentioned this pull request May 28, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants