merge redundant conversion base tree hash vars #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
gballet commented Jun 8, 2024
gballet commented Jun 8, 2024
gballet commented Jun 8, 2024
jsign approved these changes Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Over the years, two variables with very similar roles have been created:
LastMerkleRoot, that comes from the time of the replay and is used to retain the base tree. It is set at the end ofIntermediateRootbaseRootwhich is also the pointer to the root of the base tree, but is coming from the shadowfork codebase.These two variables do the same thing, and if they are not in sync, weird bugs appear. Hence the need to remove one of them.
This is a cherry-pick of #445 on top of
kaustinen-with-shapellaas something broke the shadowfork system in the t8n branch.TODO