Skip to content

Conversation

@jorinvo
Copy link
Contributor

@jorinvo jorinvo commented Mar 23, 2019

Hi there! Thank you for this excellent library!
I just came across this over here and was wondering if there is any reason behind having a docstring plus {:doc false} metadata. If this is simply some left over, I'm happy to have this merged. Otherwise feel free to close this MR. Thanks :)

@martinklepsch
Copy link

It could be the intention behind these {:doc false} flags is what you'd usually do with ^:no-doc, i.e. hiding them from documentation. Maybe it would make sense to add ^:no-doc in exchange for deleting the {:doc false} lines.

@niwinz niwinz merged commit 0cf7e78 into funcool:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants